This already looks very good! Thanks for working on this.

Yep, we have to use Arc to keep the file dialog thread safe.

Marked as ready for review, BUT I think at the very least the doc comments on the (newly exposed to the user) MetaData, Disk, Disks, and UserDirectories structs probably need updating.

@Masterchef365 Could you also add a file_system builder method to FileDialog? As with all other config values, so that you can use a FileDialog without explicitly creating a config object:

FileDialog::new().file_system(Arc::new(MyFileSystem));

The method then simply changes the file system in the config. Ty! :)

Hey @Masterchef365, I finally found the time to test all the changes. Looking good so far! Could you fix the merge conflicts so I can merge this PR? There are also Clippy and Rustfmt bugs that need to be fixed. Ty!

Rebased and force-pushed 👍

The CI is still failing. Could you take a look at that?

The CI is still failing. Could you take a look at that?

Looks like it's just some clippy lints. While many of them are fine, I think some are false-positives like making the constructors const. What do you think? If you want em resolved I'll resolve them, but in my personal opinion clippy shouldn't gate PRs for this reason.

It actually makes sense for public APIs to be set to const. So that the objects can also be created for const variables, which someone might want to do.

So yup, the clippy errors should all be fixed. A few months ago we made some extra changes to Clippy to ensure good code quality. Therefore Clippy is stricter than the default settings.